In that case, Billy's workaround is a valid fix.

Billy, if you submit the patch and I'll merge it.

Thanks,
-daw-

On 10/19/16 1:36 PM, Luke, Chris wrote:
Ahh, yes. Agree.



*From:*Burt Silverman
*Sent:* 10/19/16, 12:33 PM
*To:* Luke, Chris
*Cc:* Billy McFall, vpp-dev
*Subject:* Re: [vpp-dev] Permissions Error on Centos Vagrant VPP VM

Now I understand; this is "sudo -u vagrant" so it is not trying to become root. So it should be fine (I presume), and yes, it (SUDCOMD) has to be used consistently, across the board.

Burt

On Wed, Oct 19, 2016 at 10:13 AM, Luke, Chris <chris_l...@comcast.com <mailto:chris_l...@comcast.com>> wrote:

    Though in general less sudo is desirable than more; this is
    indicative of too much use of sudo.

    Chris.

    *From:*vpp-dev-boun...@lists.fd.io
    <mailto:vpp-dev-boun...@lists.fd.io>
    [mailto:vpp-dev-boun...@lists.fd.io
    <mailto:vpp-dev-boun...@lists.fd.io>] *On Behalf Of *Burt Silverman
    *Sent:* Wednesday, October 19, 2016 9:10 AM
    *To:* Billy McFall <bmcf...@redhat.com <mailto:bmcf...@redhat.com>>
    *Cc:* vpp-dev <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io>>
    *Subject:* Re: [vpp-dev] Permissions Error on Centos Vagrant VPP VM

    Parallelism is always nice. Looking at your snippet from git diff,
    I would say it makes sense to me that if Ubuntu requires SUDOCMD,
    then so does CentOS.

    Just my two cent(O)s.

    Burt

    On bmcf...@redhat.com> wrote:

        In the VPP Meeting 10/18/2016), Dave Wallace reported having
        issues compiling VPP in a Vagrant VM running Centos. The
        thought was it might be a MAC issue. I was able to reproduce
        on a Fedora 24 host. Dave, let me know if this is not the same
        issue you were seeing. I created Jira
        https://jira.fd.io/browse/VPP-504
        <https://jira.fd.io/browse/VPP-504> to track the issue.

        Details:

        I created a new vpp sandbox and ran vagrant vpp image with
        CentOs. The vpp build failed in the CentOs Vagrant VM as follows:

            => default: make[5]: Leaving directory
            `/home/vagrant/git/vpp/build-root/build-vpp-native/vlib-api'

            ==> default: make[4]: Leaving directory
            `/home/vagrant/git/vpp/build-root/build-vpp-native/vlib-api'

            ==> default: make[3]: Leaving directory
            `/home/vagrant/git/vpp/build-root/build-vpp-native/vlib-api'

            ==> default: @@@@ Configuring vnet in
            /home/vagrant/git/vpp/build-root/build-vpp-native/vnet @@@@

            ==> default: autom4te: cannot open
            autom4te.cache/requests: Permission denied

            ==> default: aclocal: error: echo failed with exit status: 1

            ==> default: autoreconf: aclocal failed with exit status: 1

            ==> default: make[2]: Leaving directory
            `/home/vagrant/git/vpp/build-root'

            ==> default: make[2]: *** [vnet-configure] Error 1

            ==> default: make[1]: *** [install-rpm] Error 1

            ==> default: make[1]: Leaving directory
            `/home/vagrant/git/vpp/build-root'

            ==> default: make: *** [pkg-rpm] Error 2

        As a quick test, I added 'sudo' to the 'aclocal' and
        'automake' and it builds. I don't like spraying 'sudo'
        everywhere so this is just a work around while I am still
        investigating.

            $ git diff build-root/vagrant/build.sh

            diff --git a/build-root/vagrant/build.sh
            b/build-root/vagrant/build.sh

            index e500240..76838e2 100755

            --- a/build-root/vagrant/build.sh

            +++ b/build-root/vagrant/build.sh

            @@ -68,7 +68,7 @@ $SUDOCMD make bootstrap

             if [ $DISTRIB_ID == "Ubuntu" ]; then

                 $SUDOCMD make pkg-deb

             elif [ $DISTRIB_ID == "CentOS" ]; then

            -    (cd $VPP_DIR/vnet ;aclocal; automake -a)

            +  (cd $VPP_DIR/vnet ;$SUDOCMD aclocal;$SUDOCMD automake -a)

                 $SUDOCMD make pkg-rpm

             fi

        Billy McFall


        _______________________________________________
        vpp-dev mailing list
        vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io>
        https://lists.fd.io/mailman/listinfo/vpp-dev
        <https://lists.fd.io/mailman/listinfo/vpp-dev>




_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to