Sounds like a good idea to me... Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Maciek Konstantynowicz (mkonstan) Sent: Wednesday, October 19, 2016 8:39 AM To: Damjan Marion (damarion) <damar...@cisco.com> Cc: csit-...@lists.fd.io; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] [csit-dev] DO_NOT_MERGE
+1 -Maciek On 19 Oct 2016, at 13:09, Damjan Marion (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>> wrote: Inline… On 19 Oct 2016, at 08:20, Peter Mikus -X (pmikus - PANTHEON TECHNOLOGIES at Cisco) <pmi...@cisco.com<mailto:pmi...@cisco.com>> wrote: Hello, This is more about democracy/autocracy rather than mechanics of gerrit. I’ve put -1 (with comments) in past and it was merged anyway by someone who put +2 ☺. As contributors have no -2 This can be changed. We can allow “Change Owner” to do -2. It is few clicks in gerrit admin interface. Ed? the only option is to respect voting and gently ask (by all available communication channels) for explanation. By default each -1/-2 vote must have explanation why is it there. The drawback is that voting disappear by rebase so it is not solution as it can be easily missed/removed. This is not true for -2 That is why DO_NOT_MERGE or DRAFT makes more sense. not really, as it obviously doesn’t help…. Peter Mikus Engineer – Software Cisco Systems Limited From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Keith Burns Sent: 18. októbra 2016 20:33 To: Edward Warnicke <hagb...@gmail.com<mailto:hagb...@gmail.com>>; Maciek Konstantynowicz (mkonstan) <mkons...@cisco.com<mailto:mkons...@cisco.com>> Cc: csit-...@lists.fd.io<mailto:csit-...@lists.fd.io>; Damjan Marion (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>>; vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] [csit-dev] DO_NOT_MERGE But if the contributor -1 it then I'm ok putting -2 on it as a lock if I'm a committer on that project. You can make drafts public but all that will do is force folks who like that feature (private draft) to go to github where we don't get our CSIT/verify jobs. (Drafts are an easy way to check for CSIT compliance before publish. Just add JJB as reviewer) On Tue, Oct 18, 2016, 11:24 AM Edward Warnicke <hagb...@gmail.com<mailto:hagb...@gmail.com>> wrote: I'm fine with -2, except for the problem that a contributor who is not a committer cannot -2 their patch (only committers have -2 or +2). Ed On Tue, Oct 18, 2016 at 11:11 AM, Maciek Konstantynowicz (mkonstan) <mkons...@cisco.com<mailto:mkons...@cisco.com>>wrote: +csit-dev And I asked for this merge :( Agree that -2 is best way forward. Will ask csit-dev folks to follow this practice too from now onwards. -Maciek > On 18 Oct 2016, at 18:51, Damjan Marion (damarion) > <damar...@cisco.com<mailto:damar...@cisco.com>> wrote: > > > Hey Dave, > > It can happen to anybody. I’m the first one who will do the same. > > That’s why I’m suggesting that we stop that practice. “-2” is hard lock which > will prevent merging it in until reviewer revokes it. > > D. > >> On 18 Oct 2016, at 19:29, Dave Wallace >> <dwallac...@gmail.com<mailto:dwallac...@gmail.com>> wrote: >> >> Damjan, >> >> My bad -- sorry 'bout that. Not my best day at multi-tasking :-( >> >> For those patches like the csit operational testing patch that I just >> merged, I prefer -2 so everyone can see the status of tests and help out if >> possible. >> >> I agree with Ed, that transparency is very important for community >> development. >> >> Thanks, >> -daw- >> >> On 10/18/16 1:13 PM, Damjan Marion (damarion) wrote: >>> Folks, >>> >>> We just got 1st DO_NOT_MERGE patch merged in. >>> >>> Can we going forward stop this practice, and use “-2” or Drafts instead? >>> >>> Thanks, >>> >>> Damjan >>> >>> >>> _______________________________________________ >>> vpp-dev mailing list >>> vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> >>> https://lists.fd.io/mailman/listinfo/vpp-dev >> >> _______________________________________________ >> vpp-dev mailing list >> vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> >> https://lists.fd.io/mailman/listinfo/vpp-dev > > _______________________________________________ > vpp-dev mailing list > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> > https://lists.fd.io/mailman/listinfo/vpp-dev _______________________________________________ csit-dev mailing list csit-...@lists.fd.io<mailto:csit-...@lists.fd.io> https://lists.fd.io/mailman/listinfo/csit-dev _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> https://lists.fd.io/mailman/listinfo/vpp-dev _______________________________________________ csit-dev mailing list csit-...@lists.fd.io<mailto:csit-...@lists.fd.io> https://lists.fd.io/mailman/listinfo/csit-dev
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
