Long, but below are the three types of errors I hit. I am writing a Jira
now and will submit a patch to fix them later today.
*1) There is a semi-colon at the end of the if statement. Fix was merged
yesterday.*
*vnet/vnet/fib/fib_entry_src_interface.c*
starting at line 54
if (IP_LOOKUP_NEXT_GLEAN == adj->lookup_next_index);
{
My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c: In function
‘fib_entry_src_interface_path_swap’:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c:54:2: error: this ‘if’
clause does not guard... [-Werror=misleading-indentation]
if (IP_LOOKUP_NEXT_GLEAN == adj->lookup_next_index);
^~
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c:55:9: note: ...this
statement, but the latter is misleadingly indented as if it is guarded by
the ‘if’
{
^
*2) Couple of "defined but not used" errors:*
*/vnet/vnet/mpls/interface.c*
starting on line 535
static const int dpo_next_2_mpls_post_rewrite[DPO_LAST] = {
[DPO_LOAD_BALANCE] = IP_LOOKUP_NEXT_LOAD_BALANCE,
My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/mpls/interface.c:536:18: error:
‘dpo_next_2_mpls_post_rewrite’ defined but not used [-Werror=unused-const-
variable=]
static const int dpo_next_2_mpls_post_rewrite[DPO_LAST] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
*/vnet/vnet/dpo/lookup_dpo.c*
starting on line 797
const static char* const lookup_dst_from_interface_ip4_nodes[] =
{
"lookup-ip4-dst-itf",
NULL,
};
const static char* const lookup_dst_from_interface_ip6_nodes[] =
{
"lookup-ip6-dst-itf",
NULL,
};
const static char* const lookup_dst_from_interface_mpls_nodes[] =
{
"lookup-mpls-dst-itf",
NULL,
};
const static char* const * const lookup_dst_from_interface_nodes[DPO_PROTO_NUM]
=
{
[DPO_PROTO_IP4] = lookup_dst_from_interface_ip4_nodes,
[DPO_PROTO_IP6] = lookup_dst_from_interface_ip6_nodes,
[DPO_PROTO_MPLS] = lookup_dst_from_interface_mpls_nodes,
};
My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/dpo/lookup_dpo.c:813:34: error:
‘lookup_dst_from_interface_nodes’ defined but not used
[-Werror=unused-const-variable=]
const static char* const * const
lookup_dst_from_interface_nodes[DPO_PROTO_NUM]
=
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
*3) va_arg() parameter issue:*
There are multiple instances of this. The first example is in
/vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c, but around 9 other files hit the
same issue.
starting at line 358
lisp_gpe_adjacency_format_flags_t flags =
va_arg (args, lisp_gpe_adjacency_format_flags_t);
I looked around the code, and other calls to va_arg() de-reference the
pointer to the variable 'args'. 'man va_arg()' indicates that the first
parameter is of type va_list. When I did this it compiled clean.
lisp_gpe_adjacency_format_flags_t flags =
va_arg (*args, lisp_gpe_adjacency_format_flags_t);
My Error Output:
CC vnet/dpo/lookup_dpo.lo
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c: In function
‘format_lisp_gpe_adjacency’:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c:359:5: internal compiler
error: in build_va_arg, at c-family/c-common.c:5812
va_arg (args, lisp_gpe_adjacency_format_flags_t);
^~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla> for instructions.
Preprocessed source stored into /tmp/ccVa8tTa.out file, please attach this
to your bugreport.
On Thu, Oct 13, 2016 at 10:08 AM, Damjan Marion (damarion) <
damar...@cisco.com> wrote:
>
> Hi Bill,
>
> Error output copy/pasted here or to pastebin will be a good start.
>
> Thanks,
>
> Damjan
>
> > On 13 Oct 2016, at 15:55, Billy McFall <bmcf...@redhat.com> wrote:
> >
> > I am getting build errors from a newly created sandbox based off master.
> The build errors are coming from a patch submitted 3 weeks ago. One of the
> errors was fixed yesterday as a Coverity warning. So my question is, what
> is different on my system that these are treated as errors but I haven't
> anyone else on the message board seeing the errors? Do I have an old or new
> compiler? Some additional setting? What can I dump to provide more
> information?
> >
> > Host OS: Fedora 24
> > # gcc --version
> > gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3)
> > Copyright (C) 2016 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions. There is
> NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
> PURPOSE.
> >
> > Thanks,
> > Billy McFall
> > _______________________________________________
> > vpp-dev mailing list
> > vpp-dev@lists.fd.io
> > https://lists.fd.io/mailman/listinfo/vpp-dev
>
>
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
