On 17.02.2026 11:24:45, Matias Ezequiel Vara Larsen wrote:
> +static void virtio_can_start(struct net_device *ndev)
> +{
> +     struct virtio_can_priv *priv = netdev_priv(ndev);
> +     u8 result;
> +
> +     result = virtio_can_send_ctrl_msg(ndev, VIRTIO_CAN_SET_CTRL_MODE_START);
> +     if (result != VIRTIO_CAN_RESULT_OK)
> +             netdev_err(ndev, "CAN controller start failed\n");

propagate the error value and evaluate it in the caller

[...]

> +static void virtio_can_stop(struct net_device *ndev)
> +{
> +     struct virtio_can_priv *priv = netdev_priv(ndev);
> +     struct device *dev = &priv->vdev->dev;
> +     u8 result;
> +
> +     result = virtio_can_send_ctrl_msg(ndev, VIRTIO_CAN_SET_CTRL_MODE_STOP);
> +     if (result != VIRTIO_CAN_RESULT_OK)
> +             dev_err(dev, "CAN controller stop failed\n");

propagate the error value and evaluate it in the caller

> +
> +     priv->busoff_pending = false;
> +     priv->can.state = CAN_STATE_STOPPED;
> +
> +     /* Switch carrier off if device was connected to the bus */
> +     if (netif_carrier_ok(ndev))
> +             netif_carrier_off(ndev);
> +}

regards,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature

Reply via email to