On Thu, Aug 28, 2025 at 12:01:26AM +0200, David Hildenbrand wrote:
> dma_common_contiguous_remap() is used to remap an "allocated contiguous
> region". Within a single allocation, there is no need to use nth_page()
> anymore.
>
> Neither the buddy, nor hugetlb, nor CMA will hand out problematic page
> ranges.
>
> Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Cc: Marek Szyprowski <m.szyprow...@samsung.com>
> Cc: Robin Murphy <robin.mur...@arm.com>
> Signed-off-by: David Hildenbrand <da...@redhat.com>

Nice!

LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoa...@oracle.com>

> ---
>  kernel/dma/remap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c
> index 9e2afad1c6152..b7c1c0c92d0c8 100644
> --- a/kernel/dma/remap.c
> +++ b/kernel/dma/remap.c
> @@ -49,7 +49,7 @@ void *dma_common_contiguous_remap(struct page *page, size_t 
> size,
>       if (!pages)
>               return NULL;
>       for (i = 0; i < count; i++)
> -             pages[i] = nth_page(page, i);
> +             pages[i] = page++;
>       vaddr = vmap(pages, count, VM_DMA_COHERENT, prot);
>       kvfree(pages);
>
> --
> 2.50.1
>

Reply via email to