+GPIO maintainers.
On 08-02-25, 15:54, Leng Cold wrote:
> ping
>
> Viresh Kumar <viresh.ku...@linaro.org> 于2025年1月7日周二 14:00写道：
>
> > On 06-01-25, 10:05, Viresh Kumar wrote:
> > > On 03-01-25, 16:35, hlleng wrote:
> > > > Modify the virtio-gpio driver to support multiple virtual GPIO
> > controller
> > > > instances. The previous static global irq_chip structure caused
> > conflicts
> > > > between multiple virtio-gpio device instances as they shared the same
> > > > interrupt controller configuration.
> > >
> > > What is the conflict you are getting since all it has is callbacks only,
> > I
> > > wonder why do we need to duplicate it.
> >
> > Ahh, so irq chip should be shared actually..
> >
> > static void gpiochip_set_irq_hooks(struct gpio_chip *gc)
> > {
> > ...
> >
> > /* Check if the irqchip already has this hook... */
> > if (irqchip->irq_enable == gpiochip_irq_enable ||
> > irqchip->irq_mask == gpiochip_irq_mask) {
> > /*
> > * ...and if so, give a gentle warning that this is bad
> > * practice.
> > */
> > chip_info(gc,
> > "detected irqchip that is shared with multiple
> > gpiochips: please fix the driver.\n");
> > return;
> > }
> >
> > ...
> > }
> >
> > For your patch:
> >
> > Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
--
viresh
