On Thu, Nov 30, 2023 at 12:35:09PM +0200, Yishai Hadas wrote: > On 30/11/2023 11:52, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2023 at 04:37:41PM +0200, Yishai Hadas wrote: > > > +/* Transitional device admin command. */ > > > +#define VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE 0x2 > > > +#define VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ 0x3 > > > +#define VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE 0x4 > > > +#define VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ 0x5 > > > +#define VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO 0x6 > > > + > > > +/* Increment MAX_OPCODE to next value when new opcode is added */ > > > +#define VIRTIO_ADMIN_MAX_CMD_OPCODE 0x6 > > > > Does anything need VIRTIO_ADMIN_MAX_CMD_OPCODE? Not in this > > patchset... > > > > Right, once you suggested to move to 'u64 supported_cmds' it's not any more > in use. > > It still can be used in the future, however I can drop it if it's worth a V5 > sending. > > Yishai
If you don't need it then yea, we need to be careful about what we put in uapi headers. wait with v5 until others can review v4 though. -- MST
