Hi Xuan,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    
https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/xsk-introduce-xsk_dma_ops/20230417-112903
patch link:    
https://lore.kernel.org/r/20230417032750.7086-1-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH net-next] xsk: introduce xsk_dma_ops
config: mips-randconfig-r021-20230416 
(https://download.01.org/0day-ci/archive/20230417/202304171441.ezrwcnsh-...@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 
9638da200e00bd069e6dd63604e14cbafede9324)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mipsel-linux-gnu
        # 
https://github.com/intel-lab-lkp/linux/commit/28e766603a33761d7bd1fdd3e107595408319f7d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
Xuan-Zhuo/xsk-introduce-xsk_dma_ops/20230417-112903
        git checkout 28e766603a33761d7bd1fdd3e107595408319f7d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
O=build_dir ARCH=mips SHELL=/bin/bash net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <l...@intel.com>
| Link: 
https://lore.kernel.org/oe-kbuild-all/202304171441.ezrwcnsh-...@intel.com/

All errors (new ones prefixed by >>):

>> net/xdp/xsk_buff_pool.c:430:26: error: incompatible function pointer types 
>> assigning to 'dma_addr_t (*)(struct device *, struct page *, unsigned long, 
>> size_t, enum dma_data_direction, unsigned long)' (aka 'unsigned int 
>> (*)(struct device *, struct page *, unsigned long, unsigned int, enum 
>> dma_data_direction, unsigned long)') from 'dma_addr_t (struct device *, 
>> struct page *, size_t, size_t, enum dma_data_direction, unsigned long)' (aka 
>> 'unsigned int (struct device *, struct page *, unsigned int, unsigned int, 
>> enum dma_data_direction, unsigned long)') 
>> [-Wincompatible-function-pointer-types]
                   pool->dma_ops.map_page = dma_map_page_attrs;
                                          ^ ~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +430 net/xdp/xsk_buff_pool.c

   409  
   410  int xp_dma_map(struct xsk_buff_pool *pool, struct device *dev,
   411                 struct xsk_dma_ops *dma_ops,
   412                 unsigned long attrs, struct page **pages, u32 nr_pages)
   413  {
   414          struct xsk_dma_map *dma_map;
   415          dma_addr_t dma;
   416          int err;
   417          u32 i;
   418  
   419          dma_map = xp_find_dma_map(pool);
   420          if (dma_map) {
   421                  err = xp_init_dma_info(pool, dma_map);
   422                  if (err)
   423                          return err;
   424  
   425                  refcount_inc(&dma_map->users);
   426                  return 0;
   427          }
   428  
   429          if (!dma_ops) {
 > 430                  pool->dma_ops.map_page = dma_map_page_attrs;
   431                  pool->dma_ops.mapping_error = dma_mapping_error;
   432                  pool->dma_ops.need_sync = dma_need_sync;
   433                  pool->dma_ops.sync_single_range_for_device = 
dma_sync_single_range_for_device;
   434                  pool->dma_ops.sync_single_range_for_cpu = 
dma_sync_single_range_for_cpu;
   435                  dma_ops = &pool->dma_ops;
   436          } else {
   437                  pool->dma_ops = *dma_ops;
   438          }
   439  
   440          dma_map = xp_create_dma_map(dev, pool->netdev, nr_pages, 
pool->umem);
   441          if (!dma_map)
   442                  return -ENOMEM;
   443  
   444          for (i = 0; i < dma_map->dma_pages_cnt; i++) {
   445                  dma = dma_ops->map_page(dev, pages[i], 0, PAGE_SIZE,
   446                                          DMA_BIDIRECTIONAL, attrs);
   447                  if (dma_ops->mapping_error(dev, dma)) {
   448                          __xp_dma_unmap(dma_map, dma_ops, attrs);
   449                          return -ENOMEM;
   450                  }
   451                  if (dma_ops->need_sync(dev, dma))
   452                          dma_map->dma_need_sync = true;
   453                  dma_map->dma_pages[i] = dma;
   454          }
   455  
   456          if (pool->unaligned)
   457                  xp_check_dma_contiguity(dma_map);
   458  
   459          err = xp_init_dma_info(pool, dma_map);
   460          if (err) {
   461                  __xp_dma_unmap(dma_map, dma_ops, attrs);
   462                  return err;
   463          }
   464  
   465          return 0;
   466  }
   467  EXPORT_SYMBOL(xp_dma_map);
   468  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to