On 5/6/22 17:34, Gonglei (Arei) wrote:


-----Original Message-----
From: zhenwei pi [mailto:pizhen...@bytedance.com]
Sent: Thursday, May 5, 2022 5:24 PM
To: Gonglei (Arei) <arei.gong...@huawei.com>; m...@redhat.com
Cc: jasow...@redhat.com; herb...@gondor.apana.org.au;
linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org;
linux-cry...@vger.kernel.org; helei.si...@bytedance.com;
pizhen...@bytedance.com; da...@davemloft.net
Subject: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

From: lei he <helei.si...@bytedance.com>

Enable retry for virtio-crypto-dev, so that crypto-engine can process
cipher-requests parallelly.

Cc: Michael S. Tsirkin <m...@redhat.com>
Cc: Jason Wang <jasow...@redhat.com>
Cc: Gonglei <arei.gong...@huawei.com>
Signed-off-by: lei he <helei.si...@bytedance.com>
Signed-off-by: zhenwei pi <pizhen...@bytedance.com>
---
  drivers/crypto/virtio/virtio_crypto_core.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/virtio/virtio_crypto_core.c
b/drivers/crypto/virtio/virtio_crypto_core.c
index 60490ffa3df1..f67e0d4c1b0c 100644
--- a/drivers/crypto/virtio/virtio_crypto_core.c
+++ b/drivers/crypto/virtio/virtio_crypto_core.c
@@ -144,7 +144,8 @@ static int virtcrypto_find_vqs(struct virtio_crypto *vi)
                spin_lock_init(&vi->data_vq[i].lock);
                vi->data_vq[i].vq = vqs[i];
                /* Initialize crypto engine */
-               vi->data_vq[i].engine = crypto_engine_alloc_init(dev, 1);
+               vi->data_vq[i].engine = crypto_engine_alloc_init_and_set(dev, 
true,
NULL, 1,
+                                               
virtqueue_get_vring_size(vqs[i]));

Here the '1' can be 'true' too.

Sure, you can add

Reviewed-by: Gonglei <arei.gong...@huawei.com>

Regards,
-Gonglei

                if (!vi->data_vq[i].engine) {
                        ret = -ENOMEM;
                        goto err_engine;
--
2.20.1


Thanks to Lei!

Hi, Michael
I would appreciate it if you could apply this minor change, or I send the v6 series, which one do you prefer?

--
zhenwei pi
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to