RE: [PATCH 2/7] vdpa/mlx5: Fix config_attr_mask assignment

[Parav Pandit via Virtualization]

> From: Eli Cohen <e...@nvidia.com>
> Sent: Thursday, December 2, 2021 1:27 AM
> 
> Fix VDPA_ATTR_DEV_NET_CFG_MACADDR assignment to be explicit 64 bit
> assignment.
> 
> No issue was seen since the value is well below 64 bit max value.
> Nevertheless it needs to be fixed.
> 
> Fixes: a007d940040c ("vdpa/mlx5: Support configuration of MAC")
> Signed-off-by: Eli Cohen <e...@nvidia.com>
> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 63813fbb5f62..b66f41ccbac2 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -2676,7 +2676,7 @@ static int mlx5v_probe(struct auxiliary_device *adev,
>       mgtdev->mgtdev.ops = &mdev_ops;
>       mgtdev->mgtdev.device = mdev->device;
>       mgtdev->mgtdev.id_table = id_table;
> -     mgtdev->mgtdev.config_attr_mask = (1 <<
> VDPA_ATTR_DEV_NET_CFG_MACADDR);
> +     mgtdev->mgtdev.config_attr_mask =
> +BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MACADDR);
>       mgtdev->madev = madev;
> 
>       err = vdpa_mgmtdev_register(&mgtdev->mgtdev);
> --
> 2.33.1
Reviewed-by: Parav Pandit <pa...@nvidia.com>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization