> Am 02.09.2020 um 12:15 schrieb Jürgen Groß <[email protected]>: > > On 21.08.20 12:34, David Hildenbrand wrote: >> Let's reuse the new mechanism to merge system ram resources below the >> root. We are the only one hotplugging system ram (e.g., DIMMs don't apply), >> so this is safe to be used. >> Cc: Andrew Morton <[email protected]> >> Cc: Michal Hocko <[email protected]> >> Cc: Boris Ostrovsky <[email protected]> >> Cc: Juergen Gross <[email protected]> >> Cc: Stefano Stabellini <[email protected]> >> Cc: Roger Pau Monné <[email protected]> >> Cc: Julien Grall <[email protected]> >> Cc: Pankaj Gupta <[email protected]> >> Cc: Baoquan He <[email protected]> >> Cc: Wei Yang <[email protected]> >> Signed-off-by: David Hildenbrand <[email protected]> >> --- >> drivers/xen/balloon.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c >> index 37ffccda8bb87..5ec73f752b8a7 100644 >> --- a/drivers/xen/balloon.c >> +++ b/drivers/xen/balloon.c >> @@ -338,6 +338,10 @@ static enum bp_state reserve_additional_memory(void) >> if (rc) { >> pr_warn("Cannot add additional memory (%i)\n", rc); >> goto err; >> + } else { >> + resource = NULL; >> + /* Try to reduce the number of system ram resources. */ >> + merge_system_ram_resources(&iomem_resource); >> } > > I don't see the need for setting resource to NULL and to use an "else" > clause here. >
I set it to NULL because the pointer may be stale after that call - to avoid future bugs. But I can drop it. Ack to the „else“ case. Thanks for having a look! > > Juergen > _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
