Hi Nicholas, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on tip/locking/core v5.8-rc3 next-20200702] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-queued-spinlocks-and-rwlocks/20200702-155158 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): kernel/locking/lock_events.c:61:16: warning: no previous prototype for 'lockevent_read' [-Wmissing-prototypes] 61 | ssize_t __weak lockevent_read(struct file *file, char __user *user_buf, | ^~~~~~~~~~~~~~ kernel/locking/lock_events.c: In function 'skip_lockevent': >> kernel/locking/lock_events.c:126:12: error: implicit declaration of function >> 'pv_is_native_spin_unlock' [-Werror=implicit-function-declaration] 126 | pv_on = !pv_is_native_spin_unlock(); | ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/pv_is_native_spin_unlock +126 kernel/locking/lock_events.c fb346fd9fc081c Waiman Long 2019-04-04 57 fb346fd9fc081c Waiman Long 2019-04-04 58 /* fb346fd9fc081c Waiman Long 2019-04-04 59 * The lockevent_read() function can be overridden. fb346fd9fc081c Waiman Long 2019-04-04 60 */ fb346fd9fc081c Waiman Long 2019-04-04 @61 ssize_t __weak lockevent_read(struct file *file, char __user *user_buf, fb346fd9fc081c Waiman Long 2019-04-04 62 size_t count, loff_t *ppos) fb346fd9fc081c Waiman Long 2019-04-04 63 { fb346fd9fc081c Waiman Long 2019-04-04 64 char buf[64]; fb346fd9fc081c Waiman Long 2019-04-04 65 int cpu, id, len; fb346fd9fc081c Waiman Long 2019-04-04 66 u64 sum = 0; fb346fd9fc081c Waiman Long 2019-04-04 67 fb346fd9fc081c Waiman Long 2019-04-04 68 /* fb346fd9fc081c Waiman Long 2019-04-04 69 * Get the counter ID stored in file->f_inode->i_private fb346fd9fc081c Waiman Long 2019-04-04 70 */ fb346fd9fc081c Waiman Long 2019-04-04 71 id = (long)file_inode(file)->i_private; fb346fd9fc081c Waiman Long 2019-04-04 72 fb346fd9fc081c Waiman Long 2019-04-04 73 if (id >= lockevent_num) fb346fd9fc081c Waiman Long 2019-04-04 74 return -EBADF; fb346fd9fc081c Waiman Long 2019-04-04 75 fb346fd9fc081c Waiman Long 2019-04-04 76 for_each_possible_cpu(cpu) fb346fd9fc081c Waiman Long 2019-04-04 77 sum += per_cpu(lockevents[id], cpu); fb346fd9fc081c Waiman Long 2019-04-04 78 len = snprintf(buf, sizeof(buf) - 1, "%llu\n", sum); fb346fd9fc081c Waiman Long 2019-04-04 79 fb346fd9fc081c Waiman Long 2019-04-04 80 return simple_read_from_buffer(user_buf, count, ppos, buf, len); fb346fd9fc081c Waiman Long 2019-04-04 81 } fb346fd9fc081c Waiman Long 2019-04-04 82 fb346fd9fc081c Waiman Long 2019-04-04 83 /* fb346fd9fc081c Waiman Long 2019-04-04 84 * Function to handle write request fb346fd9fc081c Waiman Long 2019-04-04 85 * fb346fd9fc081c Waiman Long 2019-04-04 86 * When idx = reset_cnts, reset all the counts. fb346fd9fc081c Waiman Long 2019-04-04 87 */ fb346fd9fc081c Waiman Long 2019-04-04 88 static ssize_t lockevent_write(struct file *file, const char __user *user_buf, fb346fd9fc081c Waiman Long 2019-04-04 89 size_t count, loff_t *ppos) fb346fd9fc081c Waiman Long 2019-04-04 90 { fb346fd9fc081c Waiman Long 2019-04-04 91 int cpu; fb346fd9fc081c Waiman Long 2019-04-04 92 fb346fd9fc081c Waiman Long 2019-04-04 93 /* fb346fd9fc081c Waiman Long 2019-04-04 94 * Get the counter ID stored in file->f_inode->i_private fb346fd9fc081c Waiman Long 2019-04-04 95 */ fb346fd9fc081c Waiman Long 2019-04-04 96 if ((long)file_inode(file)->i_private != LOCKEVENT_reset_cnts) fb346fd9fc081c Waiman Long 2019-04-04 97 return count; fb346fd9fc081c Waiman Long 2019-04-04 98 fb346fd9fc081c Waiman Long 2019-04-04 99 for_each_possible_cpu(cpu) { fb346fd9fc081c Waiman Long 2019-04-04 100 int i; fb346fd9fc081c Waiman Long 2019-04-04 101 unsigned long *ptr = per_cpu_ptr(lockevents, cpu); fb346fd9fc081c Waiman Long 2019-04-04 102 fb346fd9fc081c Waiman Long 2019-04-04 103 for (i = 0 ; i < lockevent_num; i++) fb346fd9fc081c Waiman Long 2019-04-04 104 WRITE_ONCE(ptr[i], 0); fb346fd9fc081c Waiman Long 2019-04-04 105 } fb346fd9fc081c Waiman Long 2019-04-04 106 return count; fb346fd9fc081c Waiman Long 2019-04-04 107 } fb346fd9fc081c Waiman Long 2019-04-04 108 fb346fd9fc081c Waiman Long 2019-04-04 109 /* fb346fd9fc081c Waiman Long 2019-04-04 110 * Debugfs data structures fb346fd9fc081c Waiman Long 2019-04-04 111 */ fb346fd9fc081c Waiman Long 2019-04-04 112 static const struct file_operations fops_lockevent = { fb346fd9fc081c Waiman Long 2019-04-04 113 .read = lockevent_read, fb346fd9fc081c Waiman Long 2019-04-04 114 .write = lockevent_write, fb346fd9fc081c Waiman Long 2019-04-04 115 .llseek = default_llseek, fb346fd9fc081c Waiman Long 2019-04-04 116 }; fb346fd9fc081c Waiman Long 2019-04-04 117 bf20616f46e536 Waiman Long 2019-04-04 118 #ifdef CONFIG_PARAVIRT_SPINLOCKS bf20616f46e536 Waiman Long 2019-04-04 119 #include <asm/paravirt.h> bf20616f46e536 Waiman Long 2019-04-04 120 bf20616f46e536 Waiman Long 2019-04-04 121 static bool __init skip_lockevent(const char *name) bf20616f46e536 Waiman Long 2019-04-04 122 { bf20616f46e536 Waiman Long 2019-04-04 123 static int pv_on __initdata = -1; bf20616f46e536 Waiman Long 2019-04-04 124 bf20616f46e536 Waiman Long 2019-04-04 125 if (pv_on < 0) bf20616f46e536 Waiman Long 2019-04-04 @126 pv_on = !pv_is_native_spin_unlock(); bf20616f46e536 Waiman Long 2019-04-04 127 /* bf20616f46e536 Waiman Long 2019-04-04 128 * Skip PV qspinlock events on bare metal. bf20616f46e536 Waiman Long 2019-04-04 129 */ bf20616f46e536 Waiman Long 2019-04-04 130 if (!pv_on && !memcmp(name, "pv_", 3)) bf20616f46e536 Waiman Long 2019-04-04 131 return true; bf20616f46e536 Waiman Long 2019-04-04 132 return false; bf20616f46e536 Waiman Long 2019-04-04 133 } bf20616f46e536 Waiman Long 2019-04-04 134 #else bf20616f46e536 Waiman Long 2019-04-04 135 static inline bool skip_lockevent(const char *name) bf20616f46e536 Waiman Long 2019-04-04 136 { bf20616f46e536 Waiman Long 2019-04-04 137 return false; bf20616f46e536 Waiman Long 2019-04-04 138 } bf20616f46e536 Waiman Long 2019-04-04 139 #endif bf20616f46e536 Waiman Long 2019-04-04 140 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
