On Tue, Aug 22, 2017 at 04:59:52PM +0200, Pierre Morel wrote: > unregister_virtio_driver should be done before the unregistering of > the hotplug state machine callbacks, otherwise the state machine still > holds some instance states at that time. > > Let's first unregister the virtio_net_driver first and then the hotplug > state machine callbacks. > > Signed-off-by: Pierre Morel <[email protected]>
I'm having a deja vu. Wasn't this fixed by commit cfa0ebc9d6d6308564f5174ecb655b9d504b2be5 Author: Andrew Jones <[email protected]> Date: Mon Jul 24 15:38:32 2017 +0200 virtio-net: fix module unloading already? > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 143d8a9..c042ffd 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2734,9 +2734,9 @@ module_init(virtio_net_driver_init); > > static __exit void virtio_net_driver_exit(void) > { > + unregister_virtio_driver(&virtio_net_driver); > cpuhp_remove_multi_state(CPUHP_VIRT_NET_DEAD); > cpuhp_remove_multi_state(virtionet_online); > - unregister_virtio_driver(&virtio_net_driver); > } > module_exit(virtio_net_driver_exit); > > -- > 2.7.4 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
