On Wed, Apr 15, 2009 at 07:18:44AM -0700, Eric W. Biederman wrote: > > My gut feel is that the socket needs to live in tun_file. Instead > of in tun_struct. Making that change looked just tricky enough > I couldn't sort through it when I glanced at the tun code, after I noticed > you had added a socket.
Referring to tun_file to get sk_sleep is just too error-prone. Unlike the transmit direction, the receive direction does not present itself to the easy xmit lock solution that's currently used to make tun_detach atomic. The receive callback that currently uses sk_sleep can happen anywhere. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
