https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273557
--- Comment #5 from cr...@rlwinm.de --- (In reply to Bjoern A. Zeeb from comment #3) I've seen that the ioctl() does implicitly bitwise-or in the IFF_UP flag, but it felt cleaner to explicitly request this instead of relying on this undocumented implementation detail. I confirmed it even brings the interface up if a NULL pointer is passed as argument to the ioctl(), but again that would be an ugly workaround. I agree that it would've been better to make this optional or even check the interface link state before overwriting it and only refusing to start the guest if the link can't be brought up, but I don't see any situation where the current implementation of the VMIO_SIOCSIFFLAGS ioctl() would fail on an opened tap device so the error handling code is unreachable on FreeBSD releng/13.2 and stable/14. -- You are receiving this mail because: You are the assignee for the bug.
