[virtio-dev] RE: [PATCH v12 05/10] pci: add admin vq registers to virtio over pci

[Parav Pandit]

> From: Michael S. Tsirkin <m...@redhat.com>
> Sent: Friday, May 5, 2023 11:12 AM

> > "I am thinking that aq index should not overlap with the vq index in range
> exposed by num_queues field."
> >
> > So, admin_queue_index description needs to have description like below.
> >
> > admin_queue_index must be greater than or equal to the value of
> num_queues.
> >
> > Yes?
> >
> > [1]
> > https://lore.kernel.org/virtio-dev/a4b1596c-2132-714a-7557-fa5249a5594
> > 5...@nvidia.com/
> 
> 
> this is present in the conformance clause patch:
> 
> +If VIRTIO_F_ADMIN_VQ has been negotiated, the value
> +\field{admin_queue_index} MUST be equal to, or bigger than
> +\field{num_queues}; also, \field{admin_queue_num} MUST be smaller than,
> +or equal to 0x10000 - \field{admin_queue_index}, to ensure that indices
> +of valid admin queues fit into a 16 bit range beyond all other
> +virtqueues.
Yes. this covers it. I read it before in your reply to Max few days back.

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org