On Thu, Apr 20, 2023 at 08:51:57PM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <[email protected]>
> > Sent: Thursday, April 20, 2023 4:45 PM
> > > \item[\field{config_msix_vector}]
> > > - The driver sets the Configuration Vector for MSI-X.
> > > + The driver writes the MSI-X table entry index in this field for
> > > + Configuration change notification interrupts.
> >
> >
> > Urm not exactly. there is also a special value of 0xffff.
> > I feel this here is just a high level description.
> It is high-level description. 0xffff is already covered elsewhere in the doc.
>
> > how about
> > Used by the driver to set the MSI-X vector for Configuration change
> > notification interrupts.
> >
> > pci spec also calls the entry "the vector" so I feel it's ok.
> >
>
> To keep the text consistent with rest of the fields, how about
>
> The driver writes the MSI-X table vector in this field for Configuration
> change notification interrupts.
> It uses a single verb instead two = "used" and "set".
well it's just "the MSI-X vector". not "table vector".
and personally I'd like something less verbose. yes Configuration isn't
really clear. and I dislike saying "this field" or "here" - it feels
repetetive ...
Set by the driver to the MSI-X Vector for Configuration change
notifications.
?
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
