On Thu, Mar 30 2023, Parav Pandit <[email protected]> wrote:
> Receive queue number/index example is duplicate which is already defined
> in the Setting RSS parameters section.
>
> Hence, avoid such duplicate example and prepare it for the subsequent
> patch to describe using receive queue handle.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Signed-off-by: Parav Pandit <[email protected]>
> ---
> device-types/net/description.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/device-types/net/description.tex
> b/device-types/net/description.tex
> index d7c8b1b..435c1fc 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1467,8 +1467,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device
> Types / Network Device / Devi
> The device MUST determine the destination queue for a network packet as
> follows:
> \begin{itemize}
> \item Calculate the hash of the packet as defined in \ref{sec:Device Types /
> Network Device / Device Operation / Processing of Incoming Packets / Hash
> calculation for incoming packets}.
> -\item If the device did not calculate the hash for the specific packet, the
> device directs the packet to the receiveq specified by
> \field{unclassified_queue} of virtio_net_rss_config structure (value of 0
> corresponds to receiveq1).
> -\item Apply \field{indirection_table_mask} to the calculated hash and use
> the result as the index in the indirection table to get 0-based number of
> destination receiveq (value of 0 corresponds to receiveq1).
> +\item If the device did not calculate the hash for the specific packet, the
> device directs the packet to the receiveq specified by
> \field{unclassified_queue} of virtio_net_rss_config structure.
> +\item Apply \field{indirection_table_mask} to the calculated hash and use
> the result as the index in the indirection table to get 0-based number of
> destination receiveq.
As you touch this sentence anyway, maybe make it "the 0-based number"?
> \item If the destination receive queue is being reset (See \ref{sec:Basic
> Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device
> MUST drop the packet.
> \end{itemize}
>
Otherwise,
Reviewed-by: Cornelia Huck <[email protected]>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
