On Wed, Mar 29 2023, Parav Pandit <[email protected]> wrote:

>> From: Cornelia Huck <[email protected]>
>> Sent: Wednesday, March 29, 2023 5:30 AM
>> 
>> Same comment regarding s/Previously/previously/ as for the last patch.
>>
> Will change.
>  
>> Also, I'm not that happy with the name "queue_select". Sure, it matches what
>> pci and mmio use, but ccw does not quite use the same mechanism:
>> vq_config_block is not a structure that always exists where the meaning of 
>> the
>> fields is controlled by a selector field, but a structure that is provided 
>> by the
>> caller and then filled to refer to a certain vq. I'd prefer this field to be 
>> named
>> "vq_num" or something like that.
>
> Rest of the spec uses "vqn" at places. 
> So I will change queue_select to vqn.
> Are you ok with "vqn"?

vqn works for me.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to