Nikolay Pavlov wrote: > This patch is incorrect by its nature. If “empty item” in list is > significant then `set +=` *removes* element from the list and adds a > new one, while it is supposed only to add an element. I do not know > what is the problem with &wildignore (I do not see any visible effect > from “empty item” when testing using usual tab completion), but this > patch breaks at least the following case: > > set iskeyword+=, " Add comma to &iskeyword > set iskeyword+=1 " Then add character one > > . Before the patch this sequence of commands was fine. Now it is E474 > because trailing comma was eaten while it *must not* because it is not > a typo. > > (By the way, why &path setting officially uses not “empty element”, > but “empty element *between the commas*”? If not that then it would be > another setting affected.)
Right, this change does not work for options where two commas are useful. I actually did not include part of the change that actively removed double commas, since it broke tests. I suppose we should only do this double-comma-remove for specific options, that are really a comma-separated list. Or we should just ignore double comma's. In other words: ignore empty entries. I think it's nice to avoid that += creates double commas. Let me add the P_ONECOMMA flag and set it for most options, but not 'iskeyword', 'path' and similar options. -- hundred-and-one symptoms of being an internet addict: 124. You begin conversations with, "Who is your internet service provider?" /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
