Hi Taro, 2013/7/6 Sat 15:43:27 UTC+9 Taro MURAOKA wrote: > Hi list. > > > When using vim's mercurial repository on Windows, > executing tests has some problems and is very very very stressfull. > > * converting 'ff' of *.ok and *.in causes messy status for hg. > * executing single test is failed often, > because of forgetting convert 'ff'. > * debugging and modifing tests are not easy. too many steps are > required. > > To resolve these problems, I have changed most part of > src/testdir/Make_dos.mak. What are changed: > > * Place converted files into temporary directory (dostmp). > * Set dependencies between input, temporary and output files. > * Use upper case letters for commands which derived from DOS. > > As a result of these changes, we can execute tests very easily. > > $ nmake -f Make_dos.mak win32 > $ nmake -f Make_dos.mak test87.out > $ hg status > (nothing changed, when test was succeeded) > > Please check an attached patch. > > > Best.
I think your patch is very useful, but I found an issue with it. When I wanted to run a test again, I used to delete the output then run the test. E.g.: $ nmake -f Make_dos.mak test87.out $ del test87.out $ nmake -f Make_dos.mak test87.out This doesn't work after applying your patch. (Actually, deleting dostmp\test87.out instead of test87.out works fine, but it is a little bit confusing.) Attached patch is an additional patch to the Taro's patch. Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/Make_dos.mak b/src/testdir/Make_dos.mak --- a/src/testdir/Make_dos.mak +++ b/src/testdir/Make_dos.mak @@ -70,24 +70,19 @@ win32: nolog $(SCRIPTS16) $(SCRIPTS) $(S IF EXIST $@ DEL $@ $(VIMPROG) -u dos.vim --noplugin "+set ff=dos|f $@|wq" $(*B).in -$(DOSTMP_OUTFILES): $*.in +$(TEST_OUTFILES): $(DOSTMP)\$(*B).in -@IF EXIST test.out DEL test.out MOVE $(*B).in $(*B).in.bak - COPY $*.in $(*B).in + COPY $(DOSTMP)\$(*B).in $(*B).in COPY $(*B).ok test.ok $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $(*B).in - -@IF EXIST test.out MOVE /y test.out $@ - -@IF EXIST $(*B).in.bak \ - ( DEL $(*B).in & MOVE $(*B).in.bak $(*B).in ) - -@IF EXIST test.in DEL test.in + -@IF EXIST test.out MOVE /y test.out $(DOSTMP)\$(*B).out + -@IF EXIST $(*B).in.bak MOVE /y $(*B).in.bak $(*B).in -@IF EXIST X* DEL X* -@IF EXIST test.ok DEL test.ok -@IF EXIST Xdir1 RD /s /q Xdir1 -@IF EXIST Xfind RD /s /q Xfind -@IF EXIST viminfo DEL viminfo - -$(TEST_OUTFILES): $(DOSTMP)\$(*B).out - IF EXIST test.out DEL test.out $(VIMPROG) -u dos.vim --noplugin "+set ff=unix|f test.out|wq" \ $(DOSTMP)\$(*B).out @diff test.out $*.ok & IF ERRORLEVEL 1 \
