In the future, please post a URL to the patch file instead of posting the patch. Why? Because it eats up our T1 connection deliverying the patch file to everyone on the mailing list. Thanks ken On Tue, 2001-09-04 at 12:59, Gabriel Ambuehl wrote: > -----BEGIN PGP SIGNED MESSAGE----- > > Hello all, > I think I've got together an all working vaddaliasdomain() patch and > would appreciate any comments on it. > > I did not, however, fix the issue Bill raised earlier about > vget_assign() not knowing about the aliasdomains and which makes > some of the standalone utilities fail to recognize aliasdomains which > I personally think is the required behavior as it doesn't make too > much sense to me to operate on users off aliasdomains but you're > invited to convince me otherwise and I'll try to fix this. > > Todo: > some small script that is able to change the existing, symlink based > aliasdomains to the new scheme. For the domains in ~vpopmail/domains/ > this is rather easy (i.e. check whether a given entry in that > directory is a symlink and if it is, fetch the path it points to, > call vdeldomain(entry) followed by vaddaliasdomain(entry, linkdest)). > > Please note that this isn't ultimately needed as the old aliasdomain > scheme should work without any problems even with the new stuff in > place. > > You might also want to check for compatibility with Vladimir's > authentication patches, although I highly suspect there won't be any > problems as I really tried to have the existing library functions > behave like they always did (with the above exception, of course). > > Someone might also want to check what's going to happen if there are > more than 100 aliasdomains for a given domain as I used a 100 entry > array of char * to hold the aliasdomains. In theory, the array should > get refilled after every time I use it but I wouldn't want to rely on > this without having it tested first (I was to lazy to dig into all > the > realloc() stuff as I ordinarily prefer to use C++ and the STL where > memory management is done by the lib which is why there isn't a > dynamic array instead). > > There's one other issue with the whole array too: cause the > char[] it is pointing are malloc'ed by the code and not by C itself, > they don't get destroyed after the function exits. This isn't > a problem for any program that does only one operation at a time > but for daemon like code linked against libvpopmail.a it could result > in memory leaks. The solution to this is easy: a small function that > takes the array and free() all the char[] it points to. > > > > Best regards, > Gabriel > PFi€à,Ùä" > > -----BEGIN PGP SIGNATURE----- > Version: PGP 6.5i > > iQEVAwUBO5UIe8Za2WpymlDxAQGuYAgAy8rvuFijAIWbemRyIr4tqXiW78X/h3sz > rCs5KoxnMT+9QxF0+1mL2Htx31qE+SSobDIMYkTm256D1AWSfpV9eKczPtTYtAM6 > HJIsrJFCrsC5sKpthiUW7pICV59jfOWQMP+m/3AKRfHJToJfpH/Ow7pVLDQI/QS7 > 7D0JCeBtKPTPGkyFi6cQfvkD9B/eIx9qnRa2bbjUT/rfglG9jV8+hMi2gYGm+7Us > MyDVqpXOdRzXXroUpu92Okv4rFI20oREo51f4s99Z3T/kFVP0GZVzk9MRJ9qmIWh > kV3ij8mw8d2nB8SERzswGwaaV+FgzSSZxqeQXEfVHN/ImmXAioKK+g== > =1+cA
