On Thu, 19 Feb 2026 18:14:16 GMT, Dan Heidinga <[email protected]> wrote:

>> src/hotspot/share/classfile/stackMapFrame.cpp line 55:
>> 
>>> 53:    * an error has already been determined.  This just provides a safe
>>> 54:    * obvious fallback value.
>>> 55:    */
>> 
>> I'm sorry I have an additional comment.  This should be // comments not /* 
>> per hotspot coding convention.
>
> There's already a `/* */` comment in the file.  Want me to fix both at the 
> same time?
> 
> https://github.com/DanHeidinga/valhalla/blob/a2b8ae623bdf2564626e764e2802f109790ad7d6/src/hotspot/share/classfile/stackMapFrame.cpp#L313

No, just the new one.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2130#discussion_r2829451932

Reply via email to