On Wed, 18 Feb 2026 16:20:49 GMT, Marc Chevalier <[email protected]> wrote:
>> src/hotspot/cpu/x86/frame_x86.cpp line 660: >> >>> 658: // and does not account for the return address. >>> 659: intptr_t* real_frame_size_addr = (intptr_t*) (saved_fp_addr - 1); >>> 660: int real_frame_size = (*real_frame_size_addr / wordSize) + 2; >> >> I think it'd be good to add a little comment to explain where this `2` comes >> from. Maybe mentioning what it's used for, or just send the reader to >> `remove_frame`'s comment. > > On second thought, we are very much in the guts of this exact logic, so maybe > if we wander here, we know, or we come from `remove_frame`'s neighborhood, so > maybe it'd just be noise to add such a comment. I do like the idea of using a constant for 1 and 2 in the code that reads the pc and sp., like SP_OFFSET ? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2085#discussion_r2824416346
