On Fri, 13 Feb 2026 15:52:49 GMT, Paul Hübner <[email protected]> wrote:
>> That's an actual problem with these vmTestbase jtreg tests. >> To use jdk.internal.misc.PreviewFeatures.isEnabled it is needed to add >> `@modules java.base/jdk.internal.misc`to every test. The same for >> `jdk.test.lib.Utils.getTestJavaOpts`. It is needed to ensure that >> `/test/lib` is used by every test. >> >> This file has `TODO: somehow determine the real value`. >> It would be really great to find single solution. I wonder if run something >> like VMProps in external process to obtain data would be better solution. So >> we don't need to change every single test. > > I understand. Maybe we can check both `test.java.opts` and `test.vm.opts` for > `--enable-preview` then? I'm not sure we check for `--preview` anywhere else. But I think, think we are doing these already? Not sure I following the question. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2099#discussion_r2804951617
