On Thu, 12 Feb 2026 13:30:22 GMT, Christian Hagedorn <[email protected]> wrote:
> When adding compiler replay, I've tried to only emit the additional > information value class array properties at replay dump time when we are > actually dealing with value classes (i.e. `Arguments::is_valhalla_enabled()` > is true). However, this sets an unwanted restriction: When the replay file > was created with `--enable-preview` but replay compilation runs without > `--enable-preview` (or vice versa), we run into problems. > [JDK-8377657](https://bugs.openjdk.org/browse/JDK-8377657) tried to fix this > but created new problems. I therefore suggest to just unconditionally emit > the array properties, even though they would currently not be used in > mainline. > > The `ciReplay` tests all passed with and without `--enable-preview` locally. > > Thanks, > Christian Makes sense. Thanks for quickly fixing this. ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2088#pullrequestreview-3791072211
