On Mon, 9 Feb 2026 04:12:13 GMT, Chen Liang <[email protected]> wrote:

>> Discovered this bug when prototyping core reflection. Without this fix, the 
>> test fails with:
>> 
>> testRuntimeChecks/src/Test/Test.java:7: error: bad operand type int for 
>> unary operator '<*nullrestrictedchk*>'
>>         t.work(args[0], a, b);
>>                         ^
>> testRuntimeChecks/src/Test/Test.java:7: error: bad operand type boolean for 
>> unary operator '<*nullrestrictedchk*>'
>>         t.work(args[0], a, b);
>>                            ^
>> Note: testRuntimeChecks/src/Test/Test.java uses preview features of Java SE 
>> 27.
>> Note: Recompile with -Xlint:preview for details.
>> 2 errors
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains four additional commits since 
> the last revision:
> 
>  - Move test to right place
>  - 8377334
>  - Merge branch 'bworld' of https://github.com/openjdk/valhalla into 
> fix/nullchk-arg-types-itr
>  - [bworld] Fix iterating arg types for null checks

lgtm, only a nit comment

test/langtools/tools/javac/nullability/RuntimeNullChecks.java line 3:

> 1: /*
> 2:  * Copyright (c) 2023, 2026, Oracle and/or its affiliates. All rights 
> reserved.
> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

there is no change to this file other than the copyright year

-------------

Marked as reviewed by vromero (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2056#pullrequestreview-3770688034
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2056#discussion_r2780123693

Reply via email to