On Fri, 6 Feb 2026 21:41:56 GMT, Frederic Parain <[email protected]> wrote:
>> This set of SA tests fail because SA tries to parse field layouts. With >> Valhalla there is new field info in the field stream, which is used when >> --enable-preview is used since some fields are flattened. This adds minimal >> support for that. >> >> Tested with tier1-4. > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/FieldType.java line > 53: > >> 51: break; // Ok. signature char known >> 52: default: >> 53: this.first = 'V'; // It's a value type. > > I don't understand the purpose of this line. > In signature format, `V` means void, not value type. > And value types are encoded with a L; envelope like all classes. Thank you for pointing this out. I thought I saw we were adding V for flattened fields but I was just hallucinating (like AI). This assert was caused by the misparsing of field info, so I reverted this change. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2064#discussion_r2776386592
