On Sat, 7 Feb 2026 16:30:43 GMT, Quan Anh Mai <[email protected]> wrote:
> Hi, > > This PR improves the acmp expansion: > > - Do an incremental inlining for easier graph modification. > - Take advantage of field values in addition to field types to shortcut the > substitutability check. > > Please take a look and leave your review, thanks a lot. Future improvement: We are too eager generating the null check and the type check before the call during parsing. It is probably better to put off generating them until macro expansion, so that we have a chance to generate better checks when igvn can infer more information about the operands. I tried asserting the last test case only generates 1 `CmpP`, turns out it generates 4. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2066#issuecomment-3864952011
