On Fri, 30 Jan 2026 21:25:31 GMT, Chen Liang <[email protected]> wrote:

>> PR 4 in the series of strict removal. PR 3 is #1959. PR 5 is #1961.
>> 
>> Removes all remaining occurrences of `jdk.internal.vm.annotation.Strict` and 
>> `@Strict\b` regex in all `.java` files. They are migrated to the 
>> post-processor included in this PR that is similar to test/lib 
>> ClassFileInstaller. Note there are still occurrences in jasm/jcod files, but 
>> those won't matter.
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains 13 commits:
> 
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> test/plain-strict
>  - Merge branch 'test/remove-strict' into test/plain-strict
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> test/remove-strict
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> test/remove-strict
>  - Migrate interal strict to processor anno
>  - Redundancy in dummy source
>  - Merge branch 'test/strict-out' into test/remove-strict
>  - Spurious test removal, should be removed by hotspot change instead
>  - Remove @Strict where @NullRestricted is present
>  - Purge missed jdk internal annotation export
>  - ... and 3 more: 
> https://git.openjdk.org/valhalla/compare/fe2331d9...a515b520

LGTM, thanks! I want to note that StrictStaticFieldsTest.java‎ and 
StrictInstanceFields.java remain problem listed and may require further changes 
once they're enabled

-------------

Marked as reviewed by matsaave (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/1960#pullrequestreview-3741769857

Reply via email to