On Sun, 1 Feb 2026 01:06:22 GMT, Vicente Romero <[email protected]> wrote:

> adding some additional regression tests for local proxy variables
> 
> TIA

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1548:

> 1546:                                 if (mode == 
> PrologueVisitorMode.THIS_CONSTRUCTOR) {
> 1547:                                     reportPrologueError(tree, sym);
> 1548:                                 } else if (mode == 
> PrologueVisitorMode.SUPER_CONSTRUCTOR && isInstanceField(tree)) {

not necessary with the current implementation but, not bad to be extra sure, 
future proof

test/langtools/tools/javac/valhalla/value-objects/LocalProxyVariablesTests.java 
line 86:

> 84:         doTest(
> 85:                 """
> 86:                 value class Test1 {

even though the compiler used is supposed to be reusable, using the same name 
for all classes produces an error, would be nice to fix this issue so that we 
can have a 100% reusable compiler

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2008#discussion_r2750324183
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2008#discussion_r2750327255

Reply via email to