On Thu, 29 Jan 2026 20:04:08 GMT, Chen Liang <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change from review
>
> src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 1236:
>
>> 1234: // and loosely consistent are supported.
>> 1235: int required_alignment = _payload_alignment;
>> 1236: if (has_null_free_atomic_layout() && _payload_alignment <
>> null_free_atomic_layout_size_in_bytes()) {
>
> Suggestion:
>
> if (has_null_free_atomic_layout() && required_alignment <
> null_free_atomic_layout_size_in_bytes()) {
>
> Maybe change the _payload_alignment for null_free_atomic_layout comparison to
> required_alignment too for consistency?
Updated.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1997#discussion_r2746622725
