On Thu, 29 Jan 2026 18:48:56 GMT, Joe Darcy <[email protected]> wrote:
>> Add some witnesses to UnsignedInt and basic tests.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "unsigned" in specification.
test/jdk/java/lang/UnsignedInt/BasicUnsignedIntArith.java line 38:
> 36:
> 37: if (errors > 0) {
> 38: throw new RuntimeException(errors + " errors found in
> unsigned operations.");
I recommend using junit and fail fast for individual cases - fail fast stack
traces are much easier to locate compared to an error count. In addition, we
anticipate most of the test cases to pass, so an error count is not that
valuable.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1991#discussion_r2743037385
