On Thu, 29 Jan 2026 13:29:38 GMT, Paul Hübner <[email protected]> wrote:
> Hi all, > > Currently, the non-CDS test of > `valhalla/valuetypes/SubstitutabilityTest.java` is disabled. This is because > it uses `-Xshare:off` which is fundamentally incompatible with some AOT flags > that the test is run with. > > In this fix, we introduce a new `@requires` property which denotes if the AOT > code cache has been given as a command-line argument. If that is the case, we > skip the test. For context, from the failure: >> Option AOTCache cannot be used at the same time with -Xshare:on, >> -Xshare:auto, -Xshare:off, -Xshare:dump, DumpLoadedClassList, >> SharedClassListFile, or SharedArchiveFile > > An alternative considered was to use `@requires vm.flagless`. However, there > are many configurations, such as different GCs, that we would lose out on. > Substitutability plays quite a central concept with value classes, therefore, > a new property is perhaps the more suitable approach. > > Testing: the Oracle tiers in which we observed failures, and a smoke-test > tier 1 on Linux (x64, AArch64), macOS (x64, AArch64), Windows (x64). I would avoid adding complexity to the test matrix without a clear need. (Just delete the -Xshare:off case, IMHO) ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1995#issuecomment-3818267630
