On Tue, 27 Jan 2026 22:47:22 GMT, Chen Liang <[email protected]> wrote:

>> `java.lang.reflect.Modifier` represents Java language modifiers. Since a 
>> previous iteration of JEP 401, the "identity" source modifier is removed, 
>> and only "value" source modifier exists. As a result, "identity" is no 
>> longer qualified to be present in `Modifier`. We should migrate all its uses 
>> to `ClassFile.ACC_IDENTITY` or `AccessFlag.IDENTITY` (which already 
>> correctly identifies itself not as a source modifier).
>> 
>> This also avoids the headache of `Modifier.toString` clashing over 
>> `SYNCHRONIZED` versus `IDENTITY`.
>
> Chen Liang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix identity modifier reference in getModifiers and accessFlags

Marked as reviewed by darcy (Committer).

-------------

PR Review: 
https://git.openjdk.org/valhalla/pull/1980#pullrequestreview-3714196908

Reply via email to