On Tue, 27 Jan 2026 14:14:01 GMT, Frederic Parain <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix conditionals
>
> src/hotspot/share/classfile/classFileParser.cpp line 1480:
>
>> 1478: }
>> 1479: const bool is_strict = (flags & JVM_ACC_STRICT) != 0;
>> 1480: if (!is_strict && !HAS_PENDING_EXCEPTION) {
>
> This test should not include exception checking.
> There's a bug just above, the call to `Exceptions::fthrow()` should be
> followed by a `return;` statement.
I tried to add `return;` to both `fthrow()` occurrences. The problem is that
they hit some weird assertions in runtime like when metaspace is being teared
down. I couldn't diagnose them so I resorted to `HAS_PENDING_EXCEPTION` which
runs successfully instead.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1951#discussion_r2732251119
