On Tue, 27 Jan 2026 13:57:14 GMT, Chen Liang <[email protected]> wrote:

>> When merging in [JDK-8341411](https://bugs.openjdk.org/browse/JDK-8341411), 
>> we wrongly dropped the following two similar asserts:
>> 
>> assert(C->get_alias_index(adr_type) == 
>> C->get_alias_index(_gvn.type(adr)->isa_ptr()),
>>     "slice of address and input slice don't match");
>> 
>> This was difficult to spot because `adr` was only defined further down in 
>> the code at the time of the merge. 
>> [JDK-8357474](https://bugs.openjdk.org/browse/JDK-8357474) moved `adr` up to 
>> the place where we also define it in mainline which is how it was noticed 
>> that they are missing. This patch simply adds the asserts again
>> 
>> Thanks,
>> Christian
>
> Looks right from the original patch.

Thanks @liach and @TobiHartmann for your quick reviews!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1982#issuecomment-3805384842

Reply via email to