On Thu, 22 Jan 2026 20:31:23 GMT, David Beaumont <[email protected]> wrote:
> This is a tidying up of the value class generation and management. > It solves JDK-8376088, but also simplifies the two-step process for creating > the `META-INF/preview` class files. > > Short description of changes: > 1. Remove JAR file creation (no longer needed, this is the proximal fix for > JDK-8376088). > 2. Stop adding the "intermediate" target for the compilation to the TARGETS > list (rely on the subsequent copy). > 3. Copy directories directly from the output directory to the preview > directory (does not copy marker files). > 4. Make the marker file appear alongside other markers for the module > compilation. > 5. Rename marker file to be consistent with other sibling marker files. > > The marker files in `build/linux-x64/jdk/modules/java.base/` are now: > > > _the.java.base_batch > _the.java.base_batch.cmdline > _the.java.base_batch.filelist > _the.java.base_batch.log > _the.java.base_batch.modfiles > _the.java.base_batch.modfiles.fixed > _the.java.base.config_vardeps > _the.java.base_internalapi > _the.java.base-javacserver.conf > _the.java.base_pubapi > _the.java.base.valueclasses <-- moved/renamed mark file > _the.java.base.vardeps > > > I've added a couple of notes where there could be choices about the > implementation. This pull request has now been integrated. Changeset: 2591e329 Author: David Beaumont <[email protected]> Committer: Roger Riggs <[email protected]> URL: https://git.openjdk.org/valhalla/commit/2591e32922c4b0936149b1bb75149e49dd7e66e5 Stats: 43 lines in 2 files changed: 10 ins; 22 del; 11 mod 8376088: [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files Reviewed-by: dsimms, rriggs ------------- PR: https://git.openjdk.org/valhalla/pull/1949
