On Mon, 26 Jan 2026 16:12:35 GMT, Matias Saavedra Silva <[email protected]>
wrote:
> This patch updates stackMapTableFormat.hpp to handle early_larval frames so
> they can be correctly printed in the case of verification errors, especially
> those introduced with the handling of early_larval frames and strict fields.
> Note that early_larval frames "wrap" normal stack map frames so they are
> handled differently. Verified with tier 1-5 tests.
src/hotspot/share/classfile/stackMapTableFormat.hpp line 408:
> 406: return 0; }
> 407: static u1 offset_delta_to_frame_type(int offset_delta) {
> 408: return checked_cast<u1>(246); }
Putting the closing `}` on the same line as the return is an odd formatting
convention. I know it matches the frame definition above but it's the kind of
thing I wouldn't propagate
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1973#discussion_r2728444208
