On Thu, 22 Jan 2026 23:39:39 GMT, Matias Saavedra Silva <[email protected]>
wrote:
>> Migrated value classes were previously handled with `--patch-module` and
>> lworld-specific changes were added to better handle the new use case. Now
>> that jimage is used instead, we can remove these special checks and
>> refactors to better align lworld with mainline. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix copyrights
src/hotspot/share/classfile/systemDictionary.cpp line 953:
> 951: PackageEntry* pkg_entry,
> 952: Handle class_loader) {
> 953: assert(!CDSConfig::module_patching_disables_cds(), "Cannot use CDS");
Mainline has a different assert here, should it be restore to have identical
code between lworld and jdk/master?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1950#discussion_r2722407222