On Wed, 21 Jan 2026 18:22:27 GMT, Frederic Parain <[email protected]> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused MacroAssembler::get_inline_type_field_klass > > src/hotspot/cpu/x86/interp_masm_x86.cpp line 1171: > >> 1169: >> 1170: movptr(tmp1, Address(entry, >> ResolvedFieldEntry::field_holder_offset())); >> 1171: get_inline_type_field_klass(tmp1, tmp2, field_klass); > > This was the last place where get_inline_type_field_klass() was used, so this > method can be removed from the MacroAssembler class. > Note that get_inline_type_field_klass() was not used in the aarch64 > implementation of read_flat_field(), but the get_inline_type_field_klass() > method still exists in the aarch64 MacroAssembler. This dead code could be > removed too. Good catch! I've removed `get_inline_type_field_klass` in both aarch64 and x86 implementations in a new commit. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1936#discussion_r2715937324
