On Wed, 14 Jan 2026 04:43:46 GMT, Chris Plummer <[email protected]> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   space
>
> test/jdk/com/sun/jdi/valhalla/CtorDebuggingTest.java line 69:
> 
>> 67: import com.sun.jdi.request.EventRequestManager;
>> 68: 
>> 69: public class CtorDebuggingTest extends TestScaffold {
> 
> I think this test would benefit from more comments. It would be good to 
> describe all the scenarios being tested, probably in one main comment block 
> early on, and then for implementation of each scenario add a one line comment 
> indicating which scenarios is being tested.

Added some comments

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1834#discussion_r2700169775

Reply via email to