On Wed, 14 Jan 2026 20:05:40 GMT, Coleen Phillimore <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More renaming
>
> src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 1212:
>
>> 1210: _null_free_non_atomic_layout_alignment = _payload_alignment;
>> 1211: }
>> 1212: if (UseNullableValueFlattening) {
>
> Could this be else if (UseNullableValueFlattening)? These are mutually
> exclusive iirc so the else if would make that explicit.
They are not mutually exclusive. Each layout can be enabled/disabled
individually, mostly for testing/debugging purpose.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1407#discussion_r2699412900
