On Thu, 15 Jan 2026 06:26:19 GMT, Tobias Hartmann <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add reminder at LibraryCallKit::inline_newArray
>
> src/hotspot/share/opto/macro.cpp line 489:
>
>> 487: // Cannot look through init_value if it is an oop
>> 488: if (!init_value->is_InlineType()) {
>> 489: return nullptr;
>
> I think I asked this before in another PR but I forgot in which context:
> Shouldn't `init_value` always be an `InlineTypeNode`? I think you then
> pointed by to my `TODO 8350865 [...]` comment in
> `LibraryCallKit::inline_newArray`. Once we fixed that, this check could go
> away. I think we have a few more such checks. Could you adapt the TODO in
> `LibraryCallKit::inline_newArray` with a reminder to update all those?
That's right, I have added a reminder in that method.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1909#discussion_r2693209537
