On Mon, 12 Jan 2026 15:54:50 GMT, Vicente Romero <[email protected]> wrote:
>> fixing some bugs in NullChecksWriter, reported by John Rose. In particular
>> there was no null check being generated by javac for code like:
>>
>>
>> class Test {
>> void m(String someObject) {
>> String! x = "foo";
>> x = (String)someObject; // no null check generated here
>> }
>>
>> public static void main(String... args) {
>> new Test().m(null);
>> }
>> }
>
> Vicente Romero has updated the pull request incrementally with one additional
> commit since the last revision:
>
> adding tests for return type
Looks good!
-------------
Marked as reviewed by mcimadamore (Committer).
PR Review:
https://git.openjdk.org/valhalla/pull/1883#pullrequestreview-3651504781