On Fri, 9 Jan 2026 16:24:50 GMT, Vicente Romero <[email protected]> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/lang/runtime/ArrayCreation.java line 74:
>
>> 72: */
>> 73: public static Object enumerated(Class<?> componentType, int flags,
>> Object v1, Object v2) {
>> 74: return copied(componentType, flags, 3, new Object[] { v1, v2 });
>
> length should be `2` this time, I think
whoops
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 4304:
>
>> 4302: tree.elems = translate(tree.elems, types.elemtype(tree.type));
>> 4303: if (tree.strict && tree.elems != null) {
>> 4304: Assert.check(types.dimensions(tree.type) == 1, "Unexpected
>> multi-dimensional null-restricted array");
>
> should this be a compiler error?
Yes, it should be an error (in parser). But I'm just adding a sanity check
(just in case) :-)
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1877#discussion_r2676852438
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1877#discussion_r2676851627
