On Wed, 7 Jan 2026 18:16:54 GMT, Frederic Parain <[email protected]> wrote:
>> Fix an issue in the logic processing the beginning of a field layout,
>> abstract value class with fields were processing correctly.
>>
>> Add more configurations to tests in order to cover compact object headers
>> too.
>> Re-enabled some tests that were disabled, an extended them to cover compact
>> object headers too.
>>
>> Tested with Mach5 tier 1 to 3.
>>
>> Thank you,
>>
>> Fred
>
> Frederic Parain has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix test configurations names and options
I do like these enum-like values a lot. 2 comments.
test/hotspot/jtreg/runtime/valhalla/inlinetypes/field_layout/NullMarkersTest.java
line 368:
> 366: break;
> 367: case "64_COOP_CCP_COH":
> 368: compressedOopsArg = "-XX:-UseCompressedOops";
This should be +UseCompressedOops and the one below should be
-UseCompressedOops.
test/hotspot/jtreg/runtime/valhalla/inlinetypes/field_layout/ValueFieldInheritanceTest.java
line 226:
> 224:
> 225: switch(args[0]) {
> 226: case "0":
Should be "32".
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/1862#pullrequestreview-3636209027
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1862#discussion_r2669595262
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1862#discussion_r2669598134
