On Mon, 5 Jan 2026 12:32:49 GMT, Tobias Hartmann <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - disable OSR compilation to avoid recompilation
>> - Merge branch 'lworld' into 8227588
>> - Fix JDK-8227588
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestBasicFunctionality.java
> line 382:
>
>> 380: @Test
>> 381: @IR(applyIf = {"UseArrayFlattening", "true"},
>> 382: counts = {SCOPE_OBJECT, ">= 1"}) // LOAD_OF_ANY_KLASS, "<=
>> 12"}) // TODO 8372332, 8374331 (loads should be removed)
>
> What about setting `test12` to non-(OSR)-compilable before triggering the
> deopt, i.e. once `!info.isWarmUp()`? This would prevent re-compilation. You
> can get the method via the `info` object.
That is a good idea!
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1855#discussion_r2665623693
