On Fri, 19 Dec 2025 08:14:41 GMT, Tobias Hartmann <[email protected]> wrote:
>> Marc Chevalier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Pick the right comment again > > src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 241: > >> 239: // Barriers might be emitted when converting between (scalarized) >> calling conventions for inline >> 240: // types. Save all argument registers before calling into the runtime. >> 241: __ push_call_clobbered_registers(); > > I think this comment should just be reverted to the mainline state because > it's not specific to the scalarized calling convention. Right, a manual merge accident. Oops. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1824#discussion_r2634201706
