On Thu, 18 Dec 2025 13:36:12 GMT, David Beaumont <[email protected]> wrote:

> Tidying up syncrhonization around shared image.

src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 416:

> 414:                     OPEN_FILES.put(key, sharedReader);
> 415:                 } else if (sharedReader.getByteOrder() != byteOrder) {
> 416:                     throw new IOException("\"" + sharedReader.getName() 
> + "\" is not an image file");

Its pre-existing, but ...
Testing the byteOrder and then throwing an exception that says it is not an 
Image file doesn't make sense.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1828#discussion_r2632646830

Reply via email to